This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Update DF_1_XXX from Solaris


On Fri, Nov 16, 2012 at 6:05 AM, Andreas Jaeger <aj@suse.com> wrote:
> On 11/16/2012 02:08 PM, H.J. Lu wrote:
>>
>> Hi,
>>
>> This patch updates DF_1_XXX from Solaris.  DF_1_IGNMULDEF, DF_1_NOKSYMS,
>> DF_1_NOHDR and DF_1_NORELOC are marked as "Internal use."
>>
>> OK to install?
>
>
> Does it really make sense to add these values as we do not support them at
> all? Should we add a comment that glibc does not support them?

We have a bunch of them which we don't support.

> If we install them, I suggest that you add a comment for "Internal use" to
> the once you mention above,

I think "Internal use" is even more confusing since we have no idea
what it means.


H.J.
---
> Andreas
>
>
>> Thanks.
>>
>>
>> H.J.
>> ---
>> 2012-11-16  H.J. Lu  <hongjiu.lu@intel.com>
>>
>>         * elf.h (DF_1_NODIRECT): New macro.
>>         (DF_1_IGNMULDEF): Likewise.
>>         (DF_1_NOKSYMS): Likewise.
>>         (DF_1_NOHDR): Likewise.
>>         (DF_1_EDITED): Likewise.
>>         (DF_1_NORELOC): Likewise.
>>         (DF_1_SYMINTPOSE): Likewise.
>>         (DF_1_GLOBAUDIT): Likewise.
>>         (DF_1_SINGLETON): Likewise.
>>
>> diff --git a/elf/elf.h b/elf/elf.h
>> index 1effa07..b07e6ad 100644
>> --- a/elf/elf.h
>> +++ b/elf/elf.h
>> @@ -798,6 +798,15 @@ typedef struct
>>   #define DF_1_ENDFILTEE        0x00004000      /* Filtee terminates
>> filters search. */
>>   #define       DF_1_DISPRELDNE 0x00008000      /* Disp reloc applied at
>> build time. */
>>   #define       DF_1_DISPRELPND 0x00010000      /* Disp reloc applied at
>> run-time.  */
>> +#define        DF_1_NODIRECT   0x00020000      /* Object has no-direct
>> binding. */
>> +#define        DF_1_IGNMULDEF  0x00040000
>> +#define        DF_1_NOKSYMS    0x00080000
>> +#define        DF_1_NOHDR      0x00100000
>> +#define        DF_1_EDITED     0x00200000      /* Object is modified
>> after built.  */
>> +#define        DF_1_NORELOC    0x00400000
>> +#define        DF_1_SYMINTPOSE 0x00800000      /* Object has individual
>> interposers.  */
>> +#define        DF_1_GLOBAUDIT  0x01000000      /* Global auditin
>> required.  */
>> +#define        DF_1_SINGLETON  0x02000000      /* Singleton symbols are
>> used.  */
>>
>>   /* Flags for the feature selection in DT_FEATURE_1.  */
>>   #define DTF_1_PARINIT 0x00000001
>>
>
>
> --
>  Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
>   SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>    GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
>     GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126



-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]