This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Use glibc version information in zic and zdump


On Sat, 10 Nov 2012, Mike Frysinger wrote:

> On Saturday 10 November 2012 11:57:13 Joseph S. Myers wrote:
> > On Sat, 10 Nov 2012, Mike Frysinger wrote:
> > > On Friday 09 November 2012 19:24:32 Joseph S. Myers wrote:
> > > > --- a/timezone/version.h
> > > > +++ /dev/null
> > > 
> > > add this file to .gitignore so that if someone tries to `git add` it,
> > > they'll get an error ?  or do we not expect to do syncs with tzcode in
> > > the future ?
> > 
> > Why would anyone try "git add" on this particular file name?
> 
> commit 92e4b6a92716f8b2457376291171a6330d072b0d
> Author: Joseph Myers <joseph@codesourcery.com>
> Date:   Fri Nov 9 21:20:57 2012 +0000
> 
>     Update tzcode to 2012i.
> 
>  timezone/version.h    |   1 +

I mean, why would anyone do that *in the future, accidentally*?  That 
commit was an intermediate transitional step as part of getting two 
separate but interacting changes into glibc along the lines of the 
sequence indicated in 
<http://sourceware.org/ml/libc-alpha/2012-11/msg00279.html>.  Now that we 
have got past that transitional state and have pkgversion (but not yet 
bugurl) support for timezone/ with support for generating version.h in 
timezone/Makefile, there's no reason for future merges from upstream 
tzcode to have anything to do with such a file in the source directory - 
unless upstream tzcode changes its versioning system again so that a 
source-code version.h becomes appropriate, in which case a .gitignore 
entry for version.h would just mean a make-work extra step in the update 
of editing .gitignore.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]