This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Convert Linux PowerPC <bits/fcntl.h> to use <bits/fcntl-linux.h>


Andreas Jaeger <aj@suse.com> writes:

> Double checking the headers, I notice this in
> sysdeps/unix/sysv/linux/powerpc/bits/fcntl.h:
>
> #if __WORDSIZE == 64
> # define F_GETLK64	7	/* Get record locking info.  */
> # define F_SETLK64	8	/* Set record locking info (non-blocking).  */
> # define F_SETLKW64	9	/* Set record locking info (blocking).  */
> #else
>
> These values look totally wrong to me, it doesn't make sense since we
> define F_SETLKW earlier already to 7.
>
> I would expect that it's 5, 6 and 7 for PowerPC64 (so the same as the
> non-64 bit variants) like on all other 64-bit platforms. Ryan, could you
> double check these values, please?

The original values were introduced in 4ccacaa.  Since f2481c3 a few
years later, ppc64 fcntl has mapped them to the non-64 variants.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]