Re: Use $(NM) not nm in tst-cancel-wrappers

["Carlos O'Donell" <carlos at systemhalted dot org>]

On Fri, Oct 19, 2012 at 8:12 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> On Fri, 19 Oct 2012, Carlos O'Donell wrote:
>
>> On Fri, Oct 19, 2012 at 8:29 AM, Joseph S. Myers
>> <joseph@codesourcery.com> wrote:
>> > On Thu, 18 Oct 2012, Carlos O'Donell wrote:
>> >
>> >> I would rather this variable be called something other
>> >> than nm, such that it clearly fails if the "$" is left
>> >> off by accident.
>> >
>> > I don't think the "$" being left off by accident is a significantly more
>> > plausible mistake than anything else someone might do wrong when editing
>> > this script.
>>
>> Is there any down side to calling the variable NM following what's
>> used in the configure scripts?
>>
>> It makes it easier to search for occurrences of NM, and accidental
>> removal of $ doesn't result in a script that works on native only.
>
> There isn't a specific downside, but I don't think there's any benefit
> either.  However, here is a patch version that uses NM for the variable
> name.  Tested x86_64.
>
> 2012-10-19  Jim Blandy  <jimb@codesourcery.com>
>             Joseph Myers  <joseph@codesourcery.com>
>
>         * config.make.in (NM): New variable.
>
> nptl:
> 2012-10-19  Jim Blandy  <jimb@codesourcery.com>
>             Joseph Myers  <joseph@codesourcery.com>
>
>         * Makefile ($(objpfx)tst-cancel-wrappers.out): Pass $(NM) to
>         tst-cancel-wrappers.sh.
>         * tst-cancel-wrappers.sh: Use nm program given as first argument,
>         not hardcoded "nm".

Thanks. This is perfect.

Cheers,
Carlos.