Re: [PATCH] [BZ #10631] Clarify malloc error diagnostics to avoid confusion

["Dmitry V. Levin" <ldv at altlinux dot org>]

On Tue, Sep 18, 2012 at 07:54:00AM +0530, Siddhesh Poyarekar wrote:
> On 18 September 2012 04:40, Dmitry V. Levin <ldv@altlinux.org> wrote:
> > diff --git a/ChangeLog b/ChangeLog
> > index bb46639..cb51d10 100644
> > --- a/ChangeLog
> > +++ b/ChangeLog
> > @@ -1,3 +1,8 @@
> > +2012-09-17  Dmitry V. Levin  <ldv@altlinux.org>
> > +
> > +       [BZ #10631]
> > +       * malloc.c (malloc_printerr): Clarify error message.
> > +
> >  2012-09-17  Chris Metcalf  <cmetcalf@tilera.com>
> >
> >         * crypt/md5test-giant.c (TIMEOUT): Increase to 8 minutes for tilegx.
> 
> Please review the process in the following wiki link and use it for
> your submissions:
> 
> http://sourceware.org/glibc/wiki/Contribution%20checklist
> 
> For example, the following points are incorrect in your submission:
> 
> * ChangeLog should not be posted as part of the patch

It would mean manual handling of git-format-patch output, and the result
would not be git-am'able as is.  Well, if there is a strong preference to
have posted patches different from applied patches, then OK.

> * Your submission needs a brief description of what you're trying to fix

A reference to [BZ #10631] is the brief description.

> >        __libc_message (action & 2,
> > -                     "*** glibc detected *** %s: %s: 0x%s ***\n",
> > +                     "*** glibc has detected an error in %s: %s: 0x%s ***\n",
> >                       __libc_argv[0] ?: "<unknown>", str, cp);
> >      }
> >    else if (action & 2)
> 
> The change is trivial but it may break scripts and diagnostic
> utilities that may be using the earlier format.

The message is for people rather than for automated processing by scripts.
Anyway, it is not part of libc ABI so the wording may change.  More than
that, some distributions already have this change for several years, so
any tool that rely on strict wording is already unportable.


-- 
ldv

Attachment: pgp00000.pgp
Description: PGP signature