This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] BZ #14251: Add name_to_handle_at, open_by_handle etc. toPowerPC bits/fcntl.h.


On (09/09/12 11:38), Carlos O'Donell wrote:
> On 9/9/2012 12:29 AM, Khem Raj wrote:
> > ---
> > 2012-09-08  Khem Raj <raj.khem@gmail.com>
> > 
> > 	[BZ #14251]
> > 	* sysdeps/unix/sysv/linux/powerpc/bits/fcntl.h: Define struct
> > 	file_handle and MAX_HANDLE_SZ.  Declare name_to_handle_at and
> > 	open_by_handle.
> > 
> 
> Imagine your email is like an assignment, you need to do everything
> you can so I can give you an "A" :-)
> 
> Please explain what's going on and summarize the results of your
> analysis for BZ #14251 so I Can easily review your patch.

I thought wth bugs explaining is already available in bugzilla. But here
is it is. I am building systemd for powerpc which has started to use
name_to_handle_at and hence was failing to build on powerpc but was ok
on arm or x86. Since the above bug explained the cause where the
declations were missing for powerpc

> 
> e.g.
> http://sourceware.org/glibc/wiki/Contribution%20checklist#Detailed_Explanation_of_the_Patch
> 
> * How do you know MAX_HANDLE_SZ is correct?
> 

I dont know. But systemd defaults to 128 and other ports which I modeled
this patch on (MIPS and ARM) use the same value and so does
include/linux/exportfs.h from kernel

> * Testing?

I buid and tested eglibc and systemd and ran both successfully on
powerpc target. I did not run the glibc regression testsuite.

> 
> * What does the Power maintainer have to say? I don't see Ryan or others on the CC.
> 

I hope they are watching the mailing list. 

> Thanks for the work!
> 

welcome

ps: Do I get my A :)

> Cheers,
> Carlos.
> 

-- 
-Khem


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]