Re: [PATCH] BZ #14545: Always check dtv before freeing dtv[-1]

[Andreas Jaeger <aj at suse dot com>]

On 09/06/2012 08:54 PM, H.J. Lu wrote:
> On Thu, Sep 6, 2012 at 7:11 AM, Andreas Jaeger <aj@suse.com> wrote:
> > On Thursday, September 06, 2012 06:02:00 H.J. Lu wrote:
> > > On Thu, Sep 6, 2012 at 5:49 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> > > > On Thu, Sep 6, 2012 at 1:08 AM, Andreas Jaeger <aj@suse.com> wrote:
> > > > > On Wednesday, September 05, 2012 13:21:07 H.J. Lu wrote:
> > > > > > Hi,
> > > > > >
> > > > > > We should always check dtv before freeing dtv[-1], including in
> > > > > > libc.a, since dtv is a static array in libc.a.  _dl_initial_dtv
> > > > > > is intialized to &static_dtv[1] so that index -1 contains the
> > > > > > length.
> > > > > > Testd on Linux/x86-64.  OK to install?
> > > > >
> > > > > Could you add a test for the testsuite, please?
> > > >
> > > > Many tests failed statically to due
> > > >
> > > > http://sourceware.org/bugzilla/show_bug.cgi?id=14544
> > > >
> > > > A patch was posted at
> > > >
> > > > http://sourceware.org/ml/libc-alpha/2012-09/msg00059.html
> > > >
> > > > I need to apply this before adding a test.
> > >
> > > Here is the testcase.  But it fails even with my fix for PR 14545
> > > due to PR 14544.
> >
> > Please submit the test case once both bugs are fixed.
>
> Now, PR 14544 is fixed. Here are patches for PR 14545 with
> a new case  Tested on x86-64.  OK to install?

Yes, thanks,

Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126