This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix formatting in arena.c
> OK understood, thanks. How about changes we make to the code though? Do
> we write new code or change code to GNU format or let the formatting
> be? It looks like we haven't touched the formatting at all so far in
> changes to the files, but I want to know if we would want to reconsider
> that.
I think the usual rule is to stick to the prevailing conventions in the
file when it's got a consistent style that's different from ours. When
adding entirely new code, even if intimately related to some existing code
with different style like malloc, whenever it makes sense to do it in a
separate file then that is the best thing to do and the new files of course
use our normal style. When the right thing to do is modify an existing
file that has a different style we're intentionally preserving, go with
the local flow.
Thanks,
Roland