This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Get rid of ASM_TYPE_DIRECTIVE{,_PREFIX}


On Fri, Jul 27, 2012 at 01:28:33PM -0700, Roland McGrath wrote:
> I only skimmed but this all looks fine to me.  For paranoia's sake, since
> this should not change anything, please check that no code changed for i?86
> and x86_64 (eu-elfcmp might suffice, or else objdump -d comparisons).
> It should still wait for at least two of sh, powerpc, s390 to report
> testing ok.  But since this is so mechanical and simple, I'd say if they
> are slow (like past the middle of next week, say), commit it anyway and
> just remind folks they still need to test.

Ok.  Looks like no code changed for both i?86 and x86_64:

marek@pdp-11 ~/libc-build $ eu-elfcmp -l libc.so.new libc.so
eu-elfcmp: libc.so.new libc.so differ: build ID content
marek@pdp-11 ~/libc-build $ eu-elfcmp -l ld.so.new elf/ld.so 
eu-elfcmp: ld.so.new elf/ld.so differ: build ID content

Thanks for review,

	Marek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]