This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Replace makefile fragments by use of $(eval ...)
- From: Maxim Kuvyrkov <maxim at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Andreas Schwab <schwab at linux-m68k dot org>, <libc-alpha at sourceware dot org>
- Date: Fri, 13 Jul 2012 20:39:44 +1200
- Subject: Re: [PATCH] Replace makefile fragments by use of $(eval ...)
- References: <m2fw8xm1xf.fsf@igel.home> <20120712173637.12A642C0C1@topped-with-meat.com>
On 13/07/2012, at 5:36 AM, Roland McGrath wrote:
> I don't really like this, and I don't think 2% is that compelling.
> 3.80 has a lot of questionable changes and eval is especially horrible.
Having glanced over the patch, the Makefile code looks neater and simpler after the patch.
I'm guessing that Andreas was trying to make Makefile machinery more understandable and easy to maintain, and that the speed-up was just a nice side-effect.
--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics