This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] vectorized string functions
- From: Andreas Jaeger <aj at suse dot com>
- To: libc-alpha at sourceware dot org
- Cc: OndÅej BÃlka <neleai at seznam dot cz>
- Date: Wed, 11 Jul 2012 09:23:37 +0200
- Subject: Re: [PATCH] vectorized string functions
- References: <20120711151007.GA3468@domone.rutgers.edu>
On Wednesday, July 11, 2012 17:10:07 OndÅej BÃlka wrote:
> Now I am almost done with vectorized implementation of string
> functions. I use single loop to get faster implementation of *len,
> *chr and *str functions.
Ondrej, thanks for your contribution! Do you have a copyright assignment
on place for glibc? This is definitely needed for such a large piece of
code.
Also, your code does not confirm to our coding style at all, please read
the following wiki page for details
http://sourceware.org/glibc/wiki/Contribution%20checklist
I noticed especially:
* overlong lines
* no copyright headers
* missing comments
* comments that are not full sentences
* wrong line formatting, missing spaces
This needs performance testing of all functions on a variety of
architectures. Have you done some of that already?
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix ImendÃrffer,HRB16746 (AG NÃrnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126