This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix the race between atexit() and exit()
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Peng Haitao <penght at cn dot fujitsu dot com>
- Cc: carlos at systemhalted dot org, drepper at gmail dot com, acv at linux dot vnet dot ibm dot com, libc-alpha at sourceware dot org
- Date: Mon, 9 Jul 2012 09:02:10 -0700 (PDT)
- Subject: Re: [PATCH] Fix the race between atexit() and exit()
- References: <1341539830-30671-1-git-send-email-penght@cn.fujitsu.com>
I haven't yet tried to follow the material details of the change.
But there are several pro forma issues with your patch.
The details of what you need to do are probably all mentioned in
http://sourceware.org/glibc/wiki/Contribution%20checklist
or the documents it references (and if they aren't, they should be).
So I'll just mention the problems I see without elaboration.
* File in bugzilla, refer to BZ# in ChangeLog.
* ChangeLog entry should mention global/file-level variables renamed and
introduced, as well functions touched.
* ChangeLog entry should describe changes concretely, not abstractly.
* Comment formatting.
* 'extern' declarations should be in exit.h, not in .c files.
* If a variable is a flag, use bool instead of int.
* "(foo == 1)" (for a flag) => "(foo)"
* Collapse copyright years to single range.
Thanks,
Roland