This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC: Fix for POWER7 sinf/cosf
On Wed, May 30, 2012 at 1:53 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> "Ryan S. Arnold" <ryan.arnold@gmail.com> writes:
>
>> On Tue, May 29, 2012 at 6:16 PM, Adhemerval Zanella
>> <azanella@linux.vnet.ibm.com> wrote:
>>> - Â Â Âif (x == 0.0)
>>> - Â Â Â return one;
>>> + Â Â Âferaiseexcept (FE_INEXACT);
>>> + Â Â Âreturn one;
>>
>> Call __feraiseexcept instead in order to avoid the PLT.
>
> There's a hidden_proto in include/fenv.h.
Per Roland's comments in other threads I think that the C files which
use feraiseexcept should, at least, #include <fenv.h> in order to pick
up the prototype and not rely on secondary inclusion from
math_private.h. Now whether we should then rely on the internal
fenv.h to direct feraiseexcept usage to __feraiseexcept I don't know.
Ryan