This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] add kexec_load() syscall

Hello Andreas,

thank you very much for your guiding input and helpful comments.
resent proper built tested patch.

On Wed, May 23, 2012 at 10:58:24AM +0200, Andreas Jaeger wrote:
> the first question is whether this should be really in glibc. With
> kexec-tools as only user, we should discuss a bit whether we extend
> the ABI like this.

installers are potential users as embedded boot loaders like kexecboot.
klibc supports kexec_load() syscall, but not the traditional syscall()
interface kexec-tools uses atm. Having this intelligence in libc
seems preferable.

> Regarding your contribution:
> we have some documentation about patches at
> .
> Your patch misses a ChangeLog entry describing what you do, see the
> ChangeLog file for examples. You can generate entries with Ctrl-x 4
> a from emacs.

> For larger changes, we would need the copyright assignment as well.
> Do you have one done?

Nope first time glibc touch, but this change as it is should/could be
trivial as just involving linux headers?
> system calls are added to syscalls.list. It looks like this call is
> available for all architectures, so you would add it to
> sysdeps/unix/sysv/linux/syscalls.list
> With this prototype:
> > +kexec_load (void *entry, unsigned long nr_segments,
> > +		struct kexec_segment *segments, unsigned long flags)
> The line to add would be:
> kexec_load EXTRA kexec_load i:pipi kexec_load
> And then glibc would add the syscall automatically.

thanks indeed, it does!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]