This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] We no longer have foo.s files in the tree.

On Mon, 21 May 2012, Carlos O'Donell wrote:

> On Sun, May 20, 2012 at 9:52 PM, David Miller <> wrote:
> >
> > Committed to master.
> >
> > ? ? ? ?* Makerules (sysd-rules): Remove .s from asm.
> What is someone adds a *.s, what happens now?
> Should we have a pre-commit hook that prevents this?

I see no reason to treat that differently from any other mistake someone 
might make through not keeping up with changes in glibc (e.g. putting an 
FSF paper mail address in a license comment instead of a URL) - it may be 
detected through patch review, but otherwise the file will simply be 
unused.  And I think commit hooks are generally too late for detecting 
things; anything a hook detects really ought to make the build or "make 
check" fail so you don't get surprised at commit time.  (I presume the 
reason the checks for trailing whitespace are in a hook are because the 
tree isn't currently clean for that issue - personally I'd rather clean 
that sort of thing up in a one-off pass over the whole tree, and then you 
could have the build system enforce the absence of trailing whitespace, 
but I know some people dislike that sort of global change.)

Joseph S. Myers

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]