This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Use __builtin_clzll in 64-bit __logb


On Mon, May 14, 2012 at 3:28 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> On Mon, 14 May 2012, Andreas Jaeger wrote:
>
>> On 05/11/2012 02:22 PM, H.J. Lu wrote:
>> > Hi,
>> >
>> > X32 uses 64-bit math function. ?But its long is 32bit. ?64-bit __logb
>> > should use __builtin_clzll instead of __builtin_clzl. ?Testd on Linux/x32
>> > and Linux/x86-64. ?OK to install?
>>
>> HJ, you filed bz # 14103 for this. Please add the number to ChangeLog, to NEWS
>> and mark it as resolved (the same applies for 14104),
>
> HJ, though you closed the bugs note the other parts of this request: the
> ChangeLog entry for the bug 14103 fix should include that bug number (it's
> only present for the 14104 fix) and both should be added to the list in
> the NEWS file of bugs fixed in 2.16 (whenever you fix a bug you should add
> it to that list).
>

I am checking in this patch.

-- 
H.J.
---
iff --git a/ChangeLog b/ChangeLog
index 301bcfb..e2de309 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -238,6 +238,7 @@

 2012-05-14  H.J. Lu  <hongjiu.lu@intel.com>

+	[BZ #14103]
 	* sysdeps/ieee754/dbl-64/wordsize-64/s_logb.c (__logb): Replace
 	__builtin_clzl with __builtin_clzll.

diff --git a/NEWS b/NEWS
index b9fe3b4..0e05fe4 100644
--- a/NEWS
+++ b/NEWS
@@ -25,7 +25,7 @@ Version 2.16
   13913, 13914, 13915, 13916, 13917, 13918, 13919, 13920, 13921, 13922,
   13923, 13924, 13926, 13927, 13928, 13938, 13941, 13942, 13954, 13955,
   13956, 13963, 13967, 13970, 13973, 13979, 13983, 14012, 14027, 14033,
-  14034, 14040, 14049, 14053, 14055, 14064, 14080, 14083
+  14034, 14040, 14049, 14053, 14055, 14064, 14080, 14083, 14103, 14104

 * ISO C11 support:


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]