Re: [PATCH] BZ #14059 - HAS_FMA4 check needs to also check for AVX

[Jeff Law <law at redhat dot com>]

On 05/14/2012 07:36 AM, Carlos O'Donell wrote:
> On Mon, May 14, 2012 at 4:12 AM, Andreas Jaeger<aj@suse.com>  wrote:
> > On Monday, May 14, 2012 09:52:17 Andreas Jaeger wrote:
> > > Btw. here's a small test program to show that the values are setup
> > > correctly.
> > >
> > > Currently it fails on my system (/proc/cpuinfo contains avx but
> > > glibc test reports it does not).
> > >
> > > Hope it's usefull,
> >
> > Yes, was helpfull for me;)
> >
> > I found the problem, the assignments to set the bits are wrong.
> >
> > Instead of
> > __cpu_features.feature[index_AVX_Usable] = 1;
> >
> > use
> > __cpu_features.feature[index_AVX_Usable]
> >             |= bit_AVX_Usable;
> >
> > The same for the FMA4 test.
> >
> > Carlos, I suggest to add the test to glibc as well,
>
> OK, so the next step is:
>
> * Fix the mutual recursion issue.
> * Fix the |= vs. = issue with AVX_Usable.
> * Move the FMA4 test up into the AVX test we already have.
> * Roll the extra test into the testsuite.
>
> I'll do this, retest on an system with and and without AVX and report back.
When you've got an updated patch, let me know.  I probably need to 
return my testbox today; so the window where I can test is closing rapidly.

Jeff