This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Check if RTLD_SAVESPACE_SSE is 32byte aligned

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: Roland McGrath <roland at hack dot frob dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Fri, 11 May 2012 11:49:25 -0700
Subject: Re: PATCH: Check if RTLD_SAVESPACE_SSE is 32byte aligned
References: <20120511183359.GA14491@intel.com><20120511183936.0FE0F2C0BE@topped-with-meat.com>

On Fri, May 11, 2012 at 11:39 AM, Roland McGrath <roland@hack.frob.com> wrote:
>> +#if (RTLD_SAVESPACE_SSE % 32) != 0
>> +# error "RTLD_SAVESPACE_SSE must be 32byte aligned"
>
> "aligned to 32 bytes"
> and AIUI the quotes are not needed these days (the macro won't be
> expanded in the error message).
>
> With that nit, this is fine.
>

This is the patch I am checking in.

Thanks.


-- 
H.J.
---
	* sysdeps/x86_64/dl-trampoline.S: Check if RTLD_SAVESPACE_SSE
	is 32-byte aligned.

diff --git a/sysdeps/x86_64/dl-trampoline.S b/sysdeps/x86_64/dl-trampoline.S
index 7691662..6185ba4 100644
--- a/sysdeps/x86_64/dl-trampoline.S
+++ b/sysdeps/x86_64/dl-trampoline.S
@@ -20,6 +20,10 @@
 #include <sysdep.h>
 #include <link-defines.h>

+#if (RTLD_SAVESPACE_SSE % 32) != 0
+# error RTLD_SAVESPACE_SSE must be aligned to 32 bytes
+#endif
+
 	.text
 	.globl _dl_runtime_resolve
 	.type _dl_runtime_resolve, @function

References:
- PATCH: Check if RTLD_SAVESPACE_SSE is 32byte aligned
  - From: H.J. Lu
- Re: PATCH: Check if RTLD_SAVESPACE_SSE is 32byte aligned
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]