This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Make sunrpc code available for building again


Usual style is, "New macro."

> +	* (link-obsolete-rpc): Add.

Usual style is, "New substituted variable."

> +	* sunrpc/Makefile (headers)[link-obsolete-rpc]: Add rpc headers.

Missing space before [.

> +	* nis/Makefile (headers)[link-obsolete-rpc]: Add rpc headers.

And here.

> +	* sunrpc/Makefile (shared-only-routines): Remove, so that libc.a
> +	contains the symbols.

I'd say:

	* sunrpc/Makefile (shared-only-routines): Don't set it under
	[link-obsolete-rpc], so that libc.a contains the symbols.

> +* Resurrect the RPC implementation in libc so that it can be used again for
> +  compilation of new programs. It will be removed once TI-RPC can fully
> +  replace the glibc RPC code. To use it, configure using 
> +  --enable-obsolete-rpc.

Two spaces between sentences.  This makes it sound to me like it was
removed entirely and is being put back.  I'd say:

* New configure option --enable-obsolete-rpc makes the deprecated RPC
  headers and functions available at compile time as they were before
  version 2.14.  This option will be removed at some time in the future
  after the TI-RPC library becomes fully sufficient for the needs of
  existing applications.

The substance of the change looks fine to me.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]