This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] BZ#10375: Configure magic to use -U_FORTIFY_SOURCEif needed.


On 08/05/12 09:06, Roland McGrath wrote:
> ---
>  ChangeLog      |    8 ++++++++
>  config.make.in |    2 +-
>  configure      |   35 +++++++++++++++++++++++++++++++++++
>  configure.in   |   14 ++++++++++++++
>  4 files changed, 58 insertions(+), 1 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index b80b485..338b418 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,11 @@
> +2012-05-07  Roland McGrath  <roland@hack.frob.com>
> +
> +	[BZ #10375]
> +	* configure.in: Check for _FORTIFY_SOURCE being predefined.
> +	(CPPUNDEFS): New substituted variable; add -U_FORTIFY_SOURCE if needed.
> +	* configure: Regenerated.
> +	* config.make.in (CPPFLAGS-config): Prepend @CPPUNDEFS@.
> +
>  2012-05-07  Joseph Myers  <joseph@codesourcery.com>
>  
>  	[BZ #13885]
> diff --git a/config.make.in b/config.make.in
> index 5f6f9e2..3641fb2 100644
> --- a/config.make.in
> +++ b/config.make.in
> @@ -102,7 +102,7 @@ CC = @CC@
>  CXX = @CXX@
>  BUILD_CC = @BUILD_CC@
>  CFLAGS = @CFLAGS@
> -CPPFLAGS-config = @CPPFLAGS@
> +CPPFLAGS-config = @CPPUNDEFS@ @CPPFLAGS@

Is there a reason to prepend this rather than append it?  Appending it
has the advantage of fixing the build for people who have
_FORTIFY_SOURCE defined in their default build environment CPPFLAGS
(which this currently detects but does not fix).

Allan



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]