This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Unbound alloca in crypt routines

From: Jeff Law <law at redhat dot com>
To: Roland McGrath <roland at hack dot frob dot com>
Cc: libc-alpha at sources dot redhat dot com
Date: Thu, 29 Mar 2012 12:29:17 -0600
Subject: Re: [PATCH] Unbound alloca in crypt routines
References: <4F74940F.1010702@redhat.com> <20120329171001.09DAC2C083@topped-with-meat.com>

On 03/29/2012 11:10 AM, Roland McGrath wrote:

The pontificating comments are inappropriate.  The use of
__libc_use_alloca is well established throughout the code.
It does not require any special comment, let alone a snarky one.

After reviewing your message again, it's clear you're objecting to the comment as a whole. I think you're making a mistake by objecting to the comment as a whole, but I'll remove them.

jeff

References:
- [PATCH] Unbound alloca in crypt routines
  - From: Jeff Law
- Re: [PATCH] Unbound alloca in crypt routines
  - From: Roland McGrath

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]