This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Unbound alloca in crypt routines


> Would you agree or disagree that the normal GNU style of leaving out
> braces makes code easier or harder to maintain in the long run, given
> your experience?

I prefer the established style.  It's easy to tell that the clause is only
one statement by the lack of braces.  Each pair of superfluous braces
wastes two lines, making less code visible on the screen vertically.  Each
level of superfluous braces adds a superfluous level of indentation, moving
more code to the right and eventually making it harder to fit a statement
on a line.  When a single statement needs to be replaced with a block, it's
trivial to reindent the old line and any comment lines before it.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]