This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Unbound alloca in crypt routines


On 03/29/2012 11:10 AM, Roland McGrath wrote:
The pontificating comments are inappropriate.  The use of
__libc_use_alloca is well established throughout the code.
It does not require any special comment, let alone a snarky one.
Just because it's well established throughout the code doesn't mean using alloca is good practice. In fact, I would argue that the number of fixes folks have had to make to deal with unbound allocas is good evidence that the practice of using alloca is bad.

However, I'll certainly remove that part of the comment if you object to it, and it sounds like you do. Aside from that part of the comment, what others issues need to be addressed?

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]