This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Replace Elf64_XXX with ElfW(XXX) in dl-irel.h

From: Roland McGrath <roland at hack dot frob dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Thu, 22 Mar 2012 09:55:52 -0700 (PDT)
Subject: Re: PATCH: Replace Elf64_XXX with ElfW(XXX) in dl-irel.h
References: <20120320003356.GA29917@intel.com><20120321215406.EBD202C08C@topped-with-meat.com><CAMe9rOpAaTGmDVN8zU2XS9aqYvfZ9r5e8yMDjiFk_b-gKRwi3Q@mail.gmail.com>

> +#define ELFW(type)	_ElfW (ELF, __ELF_NATIVE_CLASS, type)

This warrants a comment along the lines of the one for ElfW.

The substance of the change looks fine to me.


Thanks,
Roland

Follow-Ups:
- Re: PATCH: Replace Elf64_XXX with ElfW(XXX) in dl-irel.h
  - From: H.J. Lu

References:
- PATCH: Replace Elf64_XXX with ElfW(XXX) in dl-irel.h
  - From: H.J. Lu
- Re: PATCH: Replace Elf64_XXX with ElfW(XXX) in dl-irel.h
  - From: Roland McGrath
- Re: PATCH: Replace Elf64_XXX with ElfW(XXX) in dl-irel.h
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]