This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Configure x86_64 in sysdeps/x86_64/preconfigure

> I need to set machine, libc_cv_slibdir and libc_cv_localedir properly
> for both x86-64 and x32.  For x86-64, machine should be x86_64/64
> and for x32, machine should be x86_64/x32 so that proper sysdeps
> directories will be used.  That leaves libc_cv_slibdir and libc_cv_localedir.
> Should they be set in sysdeps/x86_64/preconfigure or
> sysdeps/unix/sysv/linux/configure?

machine belongs in preconfigure.  Nothing else does.
Send an independent change just for that.

The existing code for setting slibdir and localedir is in
sysdeps/unix/sysv/linux/configure.  There it has common cases that apply to
several 64-bit machines.  For localedir, that common case still applies to
x32.  So I think the right things to do are:

1. Separate the logic in sysdeps/unix/sysv/linux/configure so that
   it still handles localedir even if slibdir is already set.
2. Make that match x86_64* rather than just x86_64.
3. Add sysdeps/unix/sysv/linux/x86_64/x32/configure with similar logic
   for setting slibdir/libdir to the x32 names.

#1 can be its own patch.
#2 and #3 can go together in one patch, or be two separate patches.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]