This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Test for overflow exceptions in libm-test.inc
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: libc-alpha at sourceware dot org
- Date: Tue, 20 Mar 2012 01:12:17 +0000 (UTC)
- Subject: Test for overflow exceptions in libm-test.inc
Andreas correctly pointed out in
<http://sourceware.org/ml/libc-alpha/2012-03/msg00708.html> that I was
fixing a spurious overflow exception bug but adding a testcase that
wouldn't test for that bug.
I now propose this patch to enable testing for overflow exceptions in
libm-test.inc. I went through all the cases involving infinite
expected results and marked them as expecting overflow when it was an
overflow case as opposed to an exact infinity. I then tested on x86
and x86_64 and used OVERFLOW_EXCEPTION_OK as a workaround (with a
comment identifying the relevant bug) where there were spurious or
missing exceptions (only four bugs, three of them new, which is fewer
than I expected - but note that many functions probably have overflow
cases that aren't tested).
This makes it easier to fix overflow exception bugs incrementally -
you can just add tests to libm-test.inc when fixing them, or adjust an
existing test to stop using OVERFLOW_EXCEPTION_OK if the bug is one
for which a test is already present and commented.
Tested x86 and x86_64 as noted above.
2012-03-20 Joseph Myers <joseph@codesourcery.com>
* math/gen-libm-test.pl (%beautify): Add OVERFLOW_EXCEPTION and
OVERFLOW_EXCEPTION_OK.
* math/libm-test.inc ("Philosophy"): Update comment about
exception testing.
(OVERFLOW_EXCEPTION): Define.
(OVERFLOW_EXCEPTION_OK): Likewise.
(INVALID_EXCEPTION_OK): Renumber.
(DIVIDE_BY_ZERO_EXCEPTION_OK): Likewise.
(IGNORE_ZERO_INF_SIGN): Likewise.
(test_exceptions): Handle FE_OVERFLOW.
(exp10_test): Expect overflow exceptions.
(exp2_test): Likewise.
(expm1_test): Likewise.
(nextafter_test): Likewise.
(pow_test): Likewise.
(scalbn_test): Likewise.
(scalbln_test): Likewise.
diff --git a/math/gen-libm-test.pl b/math/gen-libm-test.pl
index 579fbe5..395bb65 100755
--- a/math/gen-libm-test.pl
+++ b/math/gen-libm-test.pl
@@ -1,5 +1,5 @@
#!/usr/bin/perl -w
-# Copyright (C) 1999, 2006 Free Software Foundation, Inc.
+# Copyright (C) 1999-2012 Free Software Foundation, Inc.
# This file is part of the GNU C Library.
# Contributed by Andreas Jaeger <aj@suse.de>, 1999.
@@ -78,8 +78,10 @@ use vars qw ($output_dir $ulps_file);
"M_SQRT_PIl" => "sqrt (pi)",
"INVALID_EXCEPTION" => "invalid exception",
"DIVIDE_BY_ZERO_EXCEPTION" => "division by zero exception",
+ "OVERFLOW_EXCEPTION" => "overflow exception",
"INVALID_EXCEPTION_OK" => "invalid exception allowed",
"DIVIDE_BY_ZERO_EXCEPTION_OK" => "division by zero exception allowed",
+ "OVERFLOW_EXCEPTION_OK" => "overflow exception allowed",
"EXCEPTIONS_OK" => "exceptions allowed",
"IGNORE_ZERO_INF_SIGN" => "sign of zero/inf not specified",
"INVALID_EXCEPTION|IGNORE_ZERO_INF_SIGN" => "invalid exception and sign of zero/inf not specified"
diff --git a/math/libm-test.inc b/math/libm-test.inc
index 8bb4358..af3d645 100644
--- a/math/libm-test.inc
+++ b/math/libm-test.inc
@@ -78,8 +78,8 @@
against. These implemented tests should check all cases that are
specified in ISO C99.
- Exception testing: At the moment only divide-by-zero and invalid
- exceptions are tested. Overflow/underflow and inexact exceptions
+ Exception testing: At the moment only divide-by-zero, invalid and
+ overflow exceptions are tested. Underflow and inexact exceptions
aren't checked at the moment.
NaN values: There exist signalling and quiet NaNs. This implementation
@@ -132,12 +132,14 @@
#define NO_EXCEPTION 0x0
#define INVALID_EXCEPTION 0x1
#define DIVIDE_BY_ZERO_EXCEPTION 0x2
+#define OVERFLOW_EXCEPTION 0x4
/* The next flags signals that those exceptions are allowed but not required. */
-#define INVALID_EXCEPTION_OK 0x4
-#define DIVIDE_BY_ZERO_EXCEPTION_OK 0x8
+#define INVALID_EXCEPTION_OK 0x8
+#define DIVIDE_BY_ZERO_EXCEPTION_OK 0x10
+#define OVERFLOW_EXCEPTION_OK 0x20
#define EXCEPTIONS_OK INVALID_EXCEPTION_OK+DIVIDE_BY_ZERO_EXCEPTION_OK
/* Some special test flags, passed togther with exceptions. */
-#define IGNORE_ZERO_INF_SIGN 0x10
+#define IGNORE_ZERO_INF_SIGN 0x40
/* Various constants (we must supply them precalculated for accuracy). */
#define M_PI_6l .52359877559829887307710723054658383L
@@ -451,6 +453,11 @@ test_exceptions (const char *test_name, int exception)
test_single_exception (test_name, exception, INVALID_EXCEPTION, FE_INVALID,
"Invalid operation");
#endif
+#ifdef FE_OVERFLOW
+ if ((exception & OVERFLOW_EXCEPTION_OK) == 0)
+ test_single_exception (test_name, exception, OVERFLOW_EXCEPTION,
+ FE_OVERFLOW, "Overflow");
+#endif
feclearexcept (FE_ALL_EXCEPT);
}
@@ -3074,7 +3081,7 @@ exp10_test (void)
TEST_f_f (exp10, nan_value, nan_value);
TEST_f_f (exp10, 3, 1000);
TEST_f_f (exp10, -1, 0.1L);
- TEST_f_f (exp10, 1e6, plus_infty);
+ TEST_f_f (exp10, 1e6, plus_infty, OVERFLOW_EXCEPTION);
TEST_f_f (exp10, -1e6, 0);
TEST_f_f (exp10, 0.75L, 5.62341325190349080394951039776481231L);
@@ -3101,7 +3108,8 @@ exp2_test (void)
TEST_f_f (exp2, 10, 1024);
TEST_f_f (exp2, -1, 0.5);
- TEST_f_f (exp2, 1e6, plus_infty);
+ /* Bug 13871: OVERFLOW exception may be missing. */
+ TEST_f_f (exp2, 1e6, plus_infty, OVERFLOW_EXCEPTION_OK);
TEST_f_f (exp2, -1e6, 0);
TEST_f_f (exp2, 0.75L, 1.68179283050742908606225095246642979L);
@@ -3137,7 +3145,8 @@ expm1_test (void)
#endif
errno = 0;
- TEST_f_f (expm1, 100000.0, plus_infty);
+ /* Bug 13787: OVERFLOW exception may be missing. */
+ TEST_f_f (expm1, 100000.0, plus_infty, OVERFLOW_EXCEPTION_OK);
check_int ("errno for expm1(large) == ERANGE", errno, ERANGE, 0, 0, 0);
END (expm1);
@@ -5242,8 +5251,8 @@ nextafter_test (void)
FLOAT fltmax = CHOOSE (LDBL_MAX, DBL_MAX, FLT_MAX,
LDBL_MAX, DBL_MAX, FLT_MAX);
- TEST_ff_f (nextafter, fltmax, plus_infty, plus_infty);
- TEST_ff_f (nextafter, -fltmax, minus_infty, minus_infty);
+ TEST_ff_f (nextafter, fltmax, plus_infty, plus_infty, OVERFLOW_EXCEPTION);
+ TEST_ff_f (nextafter, -fltmax, minus_infty, minus_infty, OVERFLOW_EXCEPTION);
#ifdef TEST_LDOUBLE
// XXX Enable once gcc is fixed.
@@ -5441,10 +5450,12 @@ pow_test (void)
TEST_ff_f (pow, minus_zero, -11.1L, plus_infty, DIVIDE_BY_ZERO_EXCEPTION);
check_int ("errno for pow(-0,-num) == ERANGE", errno, ERANGE, 0, 0, 0);
- TEST_ff_f (pow, 0x1p72L, 0x1p72L, plus_infty);
+ TEST_ff_f (pow, 0x1p72L, 0x1p72L, plus_infty, OVERFLOW_EXCEPTION);
TEST_ff_f (pow, 10, -0x1p72L, 0);
- TEST_ff_f (pow, max_value, max_value, plus_infty);
- TEST_ff_f (pow, 10, -max_value, 0);
+ /* Bug 13873: OVERFLOW exception may be missing. */
+ TEST_ff_f (pow, max_value, max_value, plus_infty, OVERFLOW_EXCEPTION_OK);
+ /* Bug 13872: spurious OVERFLOW exception may be present. */
+ TEST_ff_f (pow, 10, -max_value, 0, OVERFLOW_EXCEPTION_OK);
TEST_ff_f (pow, 0, 1, 0);
TEST_ff_f (pow, 0, 11, 0);
@@ -6338,13 +6349,13 @@ scalbn_test (void)
TEST_fi_f (scalbn, 1, 0L, 1);
- TEST_fi_f (scalbn, 1, INT_MAX, plus_infty);
+ TEST_fi_f (scalbn, 1, INT_MAX, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbn, 1, INT_MIN, plus_zero);
- TEST_fi_f (scalbn, max_value, INT_MAX, plus_infty);
+ TEST_fi_f (scalbn, max_value, INT_MAX, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbn, max_value, INT_MIN, plus_zero);
- TEST_fi_f (scalbn, min_value, INT_MAX, plus_infty);
+ TEST_fi_f (scalbn, min_value, INT_MAX, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbn, min_value, INT_MIN, plus_zero);
- TEST_fi_f (scalbn, min_value / 4, INT_MAX, plus_infty);
+ TEST_fi_f (scalbn, min_value / 4, INT_MAX, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbn, min_value / 4, INT_MIN, plus_zero);
END (scalbn);
@@ -6369,32 +6380,32 @@ scalbln_test (void)
TEST_fl_f (scalbln, 1, 0L, 1);
- TEST_fi_f (scalbln, 1, INT_MAX, plus_infty);
+ TEST_fi_f (scalbln, 1, INT_MAX, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbln, 1, INT_MIN, plus_zero);
- TEST_fi_f (scalbln, max_value, INT_MAX, plus_infty);
+ TEST_fi_f (scalbln, max_value, INT_MAX, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbln, max_value, INT_MIN, plus_zero);
- TEST_fi_f (scalbln, min_value, INT_MAX, plus_infty);
+ TEST_fi_f (scalbln, min_value, INT_MAX, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbln, min_value, INT_MIN, plus_zero);
- TEST_fi_f (scalbln, min_value / 4, INT_MAX, plus_infty);
+ TEST_fi_f (scalbln, min_value / 4, INT_MAX, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbln, min_value / 4, INT_MIN, plus_zero);
- TEST_fi_f (scalbln, 1, LONG_MAX, plus_infty);
+ TEST_fi_f (scalbln, 1, LONG_MAX, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbln, 1, LONG_MIN, plus_zero);
- TEST_fi_f (scalbln, max_value, LONG_MAX, plus_infty);
+ TEST_fi_f (scalbln, max_value, LONG_MAX, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbln, max_value, LONG_MIN, plus_zero);
- TEST_fi_f (scalbln, min_value, LONG_MAX, plus_infty);
+ TEST_fi_f (scalbln, min_value, LONG_MAX, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbln, min_value, LONG_MIN, plus_zero);
- TEST_fi_f (scalbln, min_value / 4, LONG_MAX, plus_infty);
+ TEST_fi_f (scalbln, min_value / 4, LONG_MAX, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbln, min_value / 4, LONG_MIN, plus_zero);
#if LONG_MAX >= 0x100000000
- TEST_fi_f (scalbln, 1, 0x88000000L, plus_infty);
+ TEST_fi_f (scalbln, 1, 0x88000000L, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbln, 1, -0x88000000L, plus_zero);
- TEST_fi_f (scalbln, max_value, 0x88000000L, plus_infty);
+ TEST_fi_f (scalbln, max_value, 0x88000000L, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbln, max_value, -0x88000000L, plus_zero);
- TEST_fi_f (scalbln, min_value, 0x88000000L, plus_infty);
+ TEST_fi_f (scalbln, min_value, 0x88000000L, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbln, min_value, -0x88000000L, plus_zero);
- TEST_fi_f (scalbln, min_value / 4, 0x88000000L, plus_infty);
+ TEST_fi_f (scalbln, min_value / 4, 0x88000000L, plus_infty, OVERFLOW_EXCEPTION);
TEST_fi_f (scalbln, min_value / 4, -0x88000000L, plus_zero);
#endif
--
Joseph S. Myers
joseph@codesourcery.com