This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove have-initfini and need-nopic-initfini
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 8 Feb 2012 10:56:12 -0800 (PST)
- Subject: Re: [PATCH] Remove have-initfini and need-nopic-initfini
- References: <m2zkctjhoz.fsf@igel.home>
> # On systems having init/fini, crt0.o is called crt1.o, and there are
> # some additional bizarre files.
Update this comment:
# The ELF convention is that the startfile is called crt1.o.
> +/* We cannot use the normal constructor mechanism to call
> __gmon_start__ because gcrt1.o appears before crtbegin.o in the link.
> Instead crti.o calls it specially (see initfini.c). */
> extern void __gmon_start__ (void);
Fix this comment not to mention initfini.c; it's just crti.S now.
With those comment fixes (and testing) go ahead and commit it.
Thanks,
Roland