This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] vfprintf: validate nargs and maybe allocate from heap
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Paul Eggert <eggert at cs dot ucla dot edu>
- Cc: Kees Cook <kees at outflux dot net>, libc-alpha at sourceware dot org
- Date: Mon, 06 Feb 2012 16:18:52 +0100
- Subject: Re: [PATCH] vfprintf: validate nargs and maybe allocate from heap
- References: <20120206062537.GM4979@outflux.net> <4F2F7E1C.5010506@cs.ucla.edu>
Paul Eggert <eggert@cs.ucla.edu> writes:
> all_done:
> if (__builtin_expect (args_malloced != NULL, 0))
> free (args_malloced);
No need for the NULL check.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."