This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 6/10] Tilera (and Linux asm-generic) support for glibc

On 11/15/2011 12:13 PM, Joseph S. Myers wrote:
> On Mon, 14 Nov 2011, Chris Metcalf wrote:
>>> Yes, FSF glibc doesn't support building glibc with -Os.
>> In practice, though, it works fine for us, once I fixed that one lone
>> callsite in faccessat() to directly call __fxstatat64().  My patch seems to
>> obsolete the patch you passed along from Sandra Loosemore; perhaps other
>> call sites have already been fixed up since then?
> Quite possibly.  Or the set of call sites may depend on the target 
> architecture (especially with the "generic" syscall interface you could be 
> using a significantly different set of call sites to other architectures).

I wanted to follow up on this; in particular, if my change to faccessat
allows glibc to build with -Os for all the "linux-generic" architectures, I
suspect it may be worth it.  It also seems to follow the convention of
using the "x" versions of the stat functions internally, and passing
_STAT_VER, to avoid the overhead of checking the version as soon as you
enter the called function.

The patch is here: .

Chris Metcalf, Tilera Corp.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]