This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH v2 6/10] Tilera (and Linux asm-generic) support for glibc
On 11/11/2011 5:02 PM, Joseph S. Myers wrote:
> On Fri, 11 Nov 2011, Chris Metcalf wrote:
>> On 11/11/2011 1:00 PM, Roland McGrath wrote:
>>>> 2011-11-03 Chris Metcalf<email@example.com>
>>>> * sysdeps/unix/sysv/linux/faccessat.c (faccessat): Use the hidden
>>>> version of fxstatat64() to avoid requiring libc_nonshared.a.
>>> You haven't explained why you think this is worthwhile.
>> The rationale for this one is that if you build glibc with "gcc -Os",
>> then the normal extern inline wrappers for fxstatat() and friends
>> don't get used in io/sys/stat.h (__USE_EXTERN_INLINES is not set), so
>> rather than becoming a direct call to __fxstatat(), it tries to
>> actually call fstatat64() directly. But for shared libc this isn't
>> available, since that symbol is defined in libc_nonshared.a, so
>> linking fails.
> Yes, FSF glibc doesn't support building glibc with -Os.
In practice, though, it works fine for us, once I fixed that one lone
callsite in faccessat() to directly call __fxstatat64(). My patch seems to
obsolete the patch you passed along from Sandra Loosemore; perhaps other
call sites have already been fixed up since then?
Chris Metcalf, Tilera Corp.