This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 0/10] Tilera (and Linux asm-generic) support for glibc


> I think there are two choices.  We can duplicate the dozen-odd files
> that use not-cancel.h in that directory into sysdeps/unix/sys/linux/generic,
> or we can apply just one #ifdef to handle the case where we need
> to use __NR_openat instead of __NR_open.  I suspect the patch to
> not-cancel.h is small enough that it's worth not duplicating the
> dozen-odd C files (about 2,700 lines total).

IMHO that change is fine enough.  But I'd like it better if it used
 #elif defined (__NR_openat)
 #else
 # error "neither __NR_open nor __NR_openat available"

for robustness.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]