This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Improve 32 bit strcat functions with SSE2/SSSE3
- From: Ulrich Drepper <drepper at gmail dot com>
- To: Dmitrieva Liubov <liubov dot dmitrieva at gmail dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, libc-alpha at sourceware dot org
- Date: Thu, 4 Aug 2011 15:35:10 -0400
- Subject: Re: PATCH: Improve 32 bit strcat functions with SSE2/SSSE3
- References: <CAHjhQ92N1KXEuq4U1i+8GouLGCnt=L-PdS_MHYSjF5HqRxezcA@mail.gmail.com><CAOPLpQcpkYiK00EDUcOevsMkB3i_sZpa+gr5=BOhNdRtrKsGEg@mail.gmail.com><CAMe9rOr62ip-uE0WGFA35jG6tJkrChwDFtiDrUukkQyVPHx3Dg@mail.gmail.com><CAHjhQ90GKGo01v4jCYVQHrANpHsaVj0P9sr7R12WW4bNzojxOQ@mail.gmail.com><CAOPLpQdAk1ya3W=ip5_S+G=Pyuc=N6cc_Kz-1QQC70_6Tkc5-g@mail.gmail.com><CAOPLpQdNmvUkq=niWef84=tDoVScQRrqVeMZBWhUw9peawnhsQ@mail.gmail.com><CAHjhQ92k-G5FxTgAM5neo+1t2ype4uPdaBd4g1r9uGmUgPLqsg@mail.gmail.com> <CAHjhQ92n2LvHEZ9hqkUT_nxgDd1pvebDA2HNLFWaRd8Av83WSw@mail.gmail.com>
On Fri, Jul 22, 2011 at 08:09, Dmitrieva Liubov
<liubov.dmitrieva@gmail.com> wrote:
> I fixed overflow bug in 32 bit patch. I've attached small fix that
> should be applied after strcat_32 patch.
> I added some tests to string/strncat.c for checking overflow bugs as well.
I applied the fixed code but not the test changes. They are not
correct. If len1 is too long you might write into the next page which
is PROT_NONE. What did you try to achieve?