This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Save and restore SSE registers in _dl_runtime_resolve.
On Tue, May 11, 2010 at 10:23 AM, Richard Henderson <rth@twiddle.net> wrote:
> On 05/11/2010 09:26 AM, Joe Damato wrote:
>> Hi,
>>
>> It seems that _dl_runtime_resolve should be saving and restoring the
>> SSE registers to comply with the amd64 ABI, unless I am reading it
>> incorrectly (and I very well could be).
>
> We only need to do that if the dynamic linker clobbers
> those registers, and it should not.
Agreed. I was erring on the side of caution and trying to be a bit
defensive with this patch. I suppose the same thing could be
accomplished with a test in the testsuite that ensures that the SSE
registers are not clobbered after invoking _dl_runtime_resolve
(however unlikely such a clobber may be).