Re: [PATCH] use HIDDEN_JUMPTARGET in ____longjmp_chk

[Mike Frysinger <vapier at gentoo dot org>]

On Wednesday 02 December 2009 08:43:22 Ulrich Drepper wrote:
> ----- "Mike Frysinger" <vapier@gentoo.org> wrote:
> > A bunch of ____longjmp_chk files mix PIC and SHARED logic under just
> > PIC.
> 
> I'm not applying patches without seeing a reason.  All this works fine for
>  me so why should I apply any of this?

if you build all of glibc with PIC (including static libs), you end up with a 
busted ____longjmp_chk object in libc.a as it refers to the internal aliased 
symbol which doesnt exist in !SHARED code.  i know this isnt a configuration 
you test and/or care about, but considering the vast majority of glibc is 
written correctly wrt SHARED and PIC defines, this merely fixes the code to 
stop assuming SHARED==PIC and !SHARED==!PIC.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.