This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Properly handle STT_GNU_IFUNC symbols in do_sym
- From: Petr Baudis <pasky at suse dot cz>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 6 Nov 2009 03:06:07 +0100
- Subject: Re: PATCH: Properly handle STT_GNU_IFUNC symbols in do_sym
- References: <20091101173418.GA4324@lucon.org>
Hi!
On Sun, Nov 01, 2009 at 09:34:18AM -0800, H.J. Lu wrote:
> do_sym should use DL_FIXUP_VALUE_XXX macros to call IFUNC function.
> Otherwise, it won't compile on ia64. This patch fixes it and adds
> a test.
BTW, are you sure the ifunc implementation in elf/dl-runtime.c is
correct on IA64? It seems to use struct fdesc * as function pointer, I
think it should use DL_FIXUP_VALUE_CODE_ADDR () instead.
--
Petr "Pasky" Baudis
A lot of people have my books on their bookshelves.
That's the problem, they need to read them. -- Don Knuth