This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix typo in iso646 gconv module
- From: AmÃrico Wang <xiyou dot wangcong at gmail dot com>
- To: Roland McGrath <roland at redhat dot com>
- Cc: Andreas Schwab <schwab at linux-m68k dot org>, libc-alpha at sourceware dot org
- Date: Sun, 20 Sep 2009 13:41:05 +0800
- Subject: Re: [PATCH] Fix typo in iso646 gconv module
- References: <m2my4qlwqi.fsf@igel.home> <20090919233816.6873413BA3@magilla.sf.frob.com>
On Sun, Sep 20, 2009 at 7:38 AM, Roland McGrath <roland@redhat.com> wrote:
> Looks obviously correct, go ahead and commit it.
>
>> Found by gcc's -Wenum-compare.
>
> Is this option new, or newly applicable to C?
Yes, please check this:
http://gcc.gnu.org/ml/gcc-patches/2009-04/msg00003.html
> (The manual I have says "(C++ and Objective-C++ only)".)
Mine too, it is a little bit out of date.
> Is it on by default, or should we be passing it?
It is enabled when -Wall in C, in C++ enabled by default.
Thanks.