This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Add AVX support to x86-64 _dl_runtime_profile
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I think I got your patches applied.
But then I changed the whole approach quite a bit. The problem is that
your patches create a writable code pointer. That's bad security-wise.
Instead I opted for the slightly slower test of a flag and just one
code path. This is a tad slower but safer.
I also fixed a few problems:
- - the decision whether to use xmm or ymm content is not all or nothing.
it's per register
- - you didn't restore the FP stack correctly after pltexit
There are two more things to do:
- - the test for AVX availability should be done only once. It should
move into the code which selected which trampoline code to use
- - the XMM restoration when YMM is available is not enough. If there
are stacked audit modules we have to check whether the XMM part is
modified, propagate the new content if necessary into the YMM
element, and update the "old value" field
Perhaps you can work on these two issues.
- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkpef0cACgkQ2ijCOnn/RHRfkQCgtL/hxY27BrGk8z1dLAQltHma
Si4AnjaFxGbtaO6NkPFm5FQvUMw/f3LL
=7y+G
-----END PGP SIGNATURE-----