This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [SH][PATCH] SH Kernel compatibility
Daniel Jacobowitz <drow@false.org> wrote:
>> OK, how about this one? The code only need the pt_regs for the size, as
>> you say. However, it does use REG_GBR, and possibly others. I've included
>> the full set of register defines, just in case.
>
>> 2009-02-03 Andrew Stubbs <ams@codesourcery.com>
>>
>> glibc/
>> * sysdeps/unix/sysv/linux/sh/sys/procfs.h: Don't include asm/elf.h.
>> (REG_REG0, REG_REG15, REG_PC, REG_PR, REG_SR, REG_GBR, REG_MACH,
>> REG_MACL, REG_MACL): Define.
>> (elf_greg_t, ELF_NGREG, elf_gregset_t, user_fpu_struct,
>> elf_fpregset_t): Copy from linux asm-sh/elf.h.
>> * sysdeps/unix/sysv/linux/sh/sys/user.h: Don't include asm/user.h.
>
> This looks good to me. Kaz, what do you think?
The patch itself looks good to me too, though the copyright
years should be updated. Also the ChangeLog entry would be
better not to refer asm-sh/elf.h and the line glibc/ should
be removed.
2009-02-dd Andrew Stubbs <ams@codesourcery.com>
* sysdeps/unix/sysv/linux/sh/sys/procfs.h: Don't include asm/elf.h.
(REG_REG0, REG_REG15, REG_PC, REG_PR, REG_SR, REG_GBR, REG_MACH,
REG_MACL, REG_MACL, elf_greg_t, ELF_NGREG, elf_gregset_t,
user_fpu_struct, elf_fpregset_t): Define.
* sysdeps/unix/sysv/linux/sh/sys/user.h: Don't include asm/user.h.
is ok.
Regards,
kaz