This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] S/390: Fix 31/64 bit utmp compat problem v3
- From: Ulrich Drepper <drepper at redhat dot com>
- To: Andreas Krebbel <Andreas dot Krebbel at de dot ibm dot com>
- Cc: libc-alpha at sourceware dot org, jakub at redhat dot com, schwidefsky at de dot ibm dot com
- Date: Tue, 08 Jul 2008 05:37:28 -0700
- Subject: Re: [PATCH] S/390: Fix 31/64 bit utmp compat problem v3
- References: <20080529145020.GA32600@homer.boeblingen.de.ibm.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andreas Krebbel wrote:
> Index: sysdeps/s390/s390-32/bits/wordsize.h
> ===================================================================
> --- sysdeps/s390/s390-32/bits/wordsize.h.orig 2008-05-28 09:39:24.000000000 +0200
> +++ sysdeps/s390/s390-32/bits/wordsize.h 2008-05-28 12:51:51.000000000 +0200
> @@ -16,3 +16,5 @@
> # define __NO_LONG_DOUBLE_MATH 1
> # endif
> #endif
> +
> +#define __UTMP_COMPAT_BASE GLIBC_2.9
This is a public header and __UTMP_COMPAT_BASE is an internal
definition. Move it to an internal header or somewhere else.
> + Contributed by Andreas Krebbel (Andreas.Krebbel@de.ibm.com).
Use < > around the email address. Everywhere.
> +/* This file provides functions converting between the 31 and 64 bit
> + struct utmp variants. */
Make up your mind. Is it 31 or 32 bits? The type certainly has 32 bits.
> + to->ut_tv.tv_sec = (int32_t)from->ut_tv.tv_sec;
> + to->ut_tv.tv_usec = (int32_t)from->ut_tv.tv_usec;
Go through the code and fix coding standard problems. Add spaces after
the closing paren etc.
- --
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkhzX4gACgkQ2ijCOnn/RHTCVQCeJQkFII7ChgmFwFwR9cV3gOqC
FYIAoMlraBewmkN6iWWrOL/LunetZqcS
=M1qS
-----END PGP SIGNATURE-----