This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

$(build-programs) and $(install-others)


if build-programs is set to no, glibc fails to install since a few binaries 
defined in $(others) have custom install rules via $(install-others).  those 
files are:
posix/Makefile: getconf
iconv/Makefile: iconv
login/Makefile: pt_chown

this is because $(others) is only respected in Makerules when 
$(build-programs) is set to "yes", but $(install-others) is always respected.  
unfortunately, we cant change Makerules to ignore $(install-others) like 
$(others) because this variable has overloaded meaning -- it installs both 
binaries and headers and other such things.

so the attached patch only sets $(install-others) for the aforementioned 
binaries in the aforementioned Makefiles when $(build-programs) is set 
to "yes".
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

2007-07-23  Mike Frysinger  <vapier@gentoo.org>

	* iconv/Makefile (install-others): Don't define if not build-programs.
	* login/Makefile (install-others): Likewise.
	* posix/Makefile (install-others): Likewise.

--- iconv/Makefile
+++ iconv/Makefile
@@ -56,8 +56,10 @@
 		  iconvconfig.h
 
 others		= iconv_prog iconvconfig
-install-others	= $(inst_bindir)/iconv
 install-sbin	= iconvconfig
+ifeq ($(build-programs),yes)
+install-others	= $(inst_bindir)/iconv
+endif
 
 CFLAGS-gconv_cache.c += -DGCONV_DIR='"$(gconvdir)"'
 CFLAGS-gconv_conf.c = -DGCONV_PATH='"$(gconvdir)"'
--- login/Makefile
+++ login/Makefile
@@ -30,7 +30,9 @@
 CFLAGS-grantpt.c = -DLIBEXECDIR='"$(libexecdir)"'
 
 others = utmpdump pt_chown
+ifeq ($(build-programs),yes)
 install-others = $(inst_libexecdir)/pt_chown
+endif
 
 distribute := utmp-private.h utmp-equal.h pty-private.h
 
--- posix/Makefile
+++ posix/Makefile
@@ -98,7 +98,9 @@
 endif
 others		:= getconf
 install-bin	:= getconf
+ifeq ($(build-programs),yes)
 install-others	:= $(inst_libexecdir)/getconf
+endif
 
 before-compile	:= testcases.h ptestcases.h
 

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]