This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC thread pointer bias requires powerpc/lowlevelrobustlock.sym
- From: "Ryan S. Arnold" <rsa at us dot ibm dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: libc-alpha at sourceware dot org, Benjamin Herrenschmidt <benh at kernel dot crashing dot org>, Ben Collins <ben dot collins at ubuntu dot com>, Fabio Massimo Di Nitto <fabbione at ubuntu dot com>, Jeff Bailey <jbailey at ubuntu dot com>, Paul Mackerras <paulus at samba dot org>, Steve Munroe <sjmunroe at us dot ibm dot com>
- Date: Thu, 02 Nov 2006 10:20:21 -0600
- Subject: Re: [PATCH] PowerPC thread pointer bias requires powerpc/lowlevelrobustlock.sym
- References: <1162426488.28331.0.camel@ryanarn-desktop> <20061102131356.GA5868@sunsite.mff.cuni.cz>
On Thu, 2006-11-02 at 14:13 +0100, Jakub Jelinek wrote:
> Can you explain how this patch can change a single bit in the powerpc libraries?
> lowlevelrobustlock.sym is the source for glibc buildtime generated
> lowlevelrobustlock.h header.
> This header is used in exactly 3 files in glibc sources:
>
> nptl/sysdeps/unix/sysv/linux/sh/lowlevelrobustlock.S:#include <lowlevelrobustlock.h>
> nptl/sysdeps/unix/sysv/linux/i386/i486/lowlevelrobustlock.S:#include <lowlevelrobustlock.h>
> nptl/sysdeps/unix/sysv/linux/x86_64/lowlevelrobustlock.S:#include <lowlevelrobustlock.h>
>
> as the directories clearly suggest, these have nothing to do with powerpc.
>
> Uli, as TID is defined in tcb-offsets.{sym,h}, I think we should just nuke
> lowlevelrobustlock.sym and s/<lowlevelrobustlock.h>/<tcb-offsets.h>/
> in those 3 files.
>
> Jakub
Jakub, You are correct. This was presumptuous on my part. I don't
recall the original bug I ran into that I thought this would fix but it
certainly won't fix the problem that Ben H. and company are running
into. I'll continue to investigate that issue.
Ryan S. Arnold
IBM Linux Technology Center