This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
[PATCH] Use printf instead of echo for some shells.
- From: GOTO Masanori <gotom at debian dot or dot jp>
- To: libc-alpha at sources dot redhat dot com, roland at redhat dot com
- Cc: gotom at debian dot or dot jp
- Date: Sun, 27 Feb 2005 10:20:09 +0900
- Subject: [PATCH] Use printf instead of echo for some shells.
This patch does not generate invalid csu/version-info.h which has
unterminating " line because some /bin/sh cannot parse correctly. The
previous discussion was:
http://sources.redhat.com/ml/libc-alpha/2004-08/msg00129.html
http://sources.redhat.com/ml/libc-alpha/2004-08/msg00145.html
This patch gets rid of all this issue because the conclusion of the
discussion was to use printf instead of echo. Roland, could you look
at it again?
Regards,
-- gotom
2005-02-26 GOTO Masanori <gotom@debian.or.jp>
* csu/Makefile: Use printf instead of echo for some shells.
Index: csu/Makefile
===================================================================
RCS file: /cvs/glibc/libc/csu/Makefile,v
retrieving revision 1.75
diff -u -p -r1.75 Makefile
--- csu/Makefile 3 Jan 2005 17:57:14 -0000 1.75
+++ csu/Makefile 27 Feb 2005 01:17:49 -0000
@@ -241,7 +241,7 @@ $(objpfx)version-info.h: $(common-objpfx
esac; \
files="$(all-Banner-files)"; \
if test -n "$$files"; then \
- echo "\"Available extensions:\\n\""; \
+ printf '"Available extensions:\\n"\n'; \
sed -e '/^#/d' -e 's/^[[:space:]]*/ /' \
-e 's/^\(.*\)$$/\"\1\\n\"/' $$files; \
fi) > $@T