This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] fix glibc-cvs for linux+nptl+static
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Eric Valette <eric dot valette at free dot fr>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Fri, 12 Nov 2004 11:49:57 +0100
- Subject: Re: [PATCH] fix glibc-cvs for linux+nptl+static
- References: <41949213.8090104@free.fr>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Nov 12, 2004 at 11:36:03AM +0100, Eric Valette wrote:
> Hi,
>
> The following configuration options leads to some problems :
>
> ../libc/configure --host=i486-linux --build=i486-linux --without-cvs
> --enable-add-ons=nptl --with-tls --disable-shared --with-__thread
> --enable-kernel=2.6.0 --prefix=/usr/local/npltstatic
> --oldincludedir=/usr/include CC=gcc-3.4 CPPFLAGS='-isystem
> /usr/src/linux/include' --with-headers=/usr/src/linux/include
>
> I managed to compile and run the Open Posix test suite conformance test
> with the attached patch applied.
>
> Fill free to comment if I misunderstood something and patch is incorrect.
The elf/Makefile change looks ok, but you forgot ChangeLog entry.
> --- libc/sysdeps/unix/sysv/linux/i386/syscalls.list.~1.19.~ 2004-03-10 09:38:15.000000000 +0100
> +++ libc/sysdeps/unix/sysv/linux/i386/syscalls.list 2004-11-03 23:45:10.000000000 +0100
> @@ -2,7 +2,7 @@
>
> modify_ldt EXTRA modify_ldt i:ipi __modify_ldt modify_ldt
> vm86old EXTRA vm86old i:p __vm86old vm86@GLIBC_2.0
> -vm86 - vm86 i:ip __vm86 vm86@@GLIBC_2.3.4
> +vm86 - vm86 i:ip __vm86 vm86
> oldgetrlimit EXTRA getrlimit i:ip __old_getrlimit getrlimit@GLIBC_2.0
> oldsetrlimit EXTRA setrlimit i:ip __old_setrlimit setrlimit@GLIBC_2.0
> time - time Ei:p time
This looks wrong, please explain.
> --- libc/sysdeps/unix/sysv/linux/i386/setegid.c.~1.7.~ 2004-09-20 01:44:35.000000000 +0200
> +++ libc/sysdeps/unix/sysv/linux/i386/setegid.c 2004-11-04 00:11:56.000000000 +0100
...
> --- libc/sysdeps/unix/sysv/linux/i386/setuid.c.~1.8.~ 2004-09-25 09:43:55.000000000 +0200
> +++ libc/sysdeps/unix/sysv/linux/i386/setuid.c 2004-11-04 11:24:52.000000000 +0100
All these changes are incorrect, please update to current CVS.
> --- libc/sysdeps/unix/sysv/linux/Makefile.~1.144.~ 2004-10-05 01:29:06.000000000 +0200
> +++ libc/sysdeps/unix/sysv/linux/Makefile 2004-11-11 23:39:40.000000000 +0100
> @@ -149,6 +149,7 @@
> ifeq ($(subdir),rt)
> CFLAGS-mq_send.c += -fexceptions
> CFLAGS-mq_receive.c += -fexceptions
> +sysdep_routines += mq_close mq_notify mq_receive mq_unlink mq_getattr mq_open mq_send shm_open shmat shmctl shmdt shm_open shm_unlink
> endif
>
> ifeq ($(subdir),nscd)
And this is incorrect too. mq_open etc. are in librt.a and librt.so, they
are not supposed to be in libc.
Jakub