This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] Several GNU/Hurd fixes
- From: Jeroen Dekkers <jeroen at dekkers dot cx>
- To: Roland McGrath <roland at redhat dot com>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Fri, 07 May 2004 23:23:51 +0200
- Subject: Re: [PATCH] Several GNU/Hurd fixes
At Fri, 7 May 2004 14:06:47 -0700,
Roland McGrath wrote:
>
> > The following patch fixes several bugs for GNU/Hurd. The
> > CFLAGS-init-first.c changes fixes a gcc 3.4 error because it wants to
> > use ebp in doinit() for the frame pointer, but we already use it in
> > the assembly code.
>
> Please elaborate on the problem. The asm in doinit should not care about
> the prior register usage.
I get the following error message:
../sysdeps/mach/hurd/i386/init-first.c: In function `doinit':
../sysdeps/mach/hurd/i386/init-first.c:352: error: bp cannot be used in asm here
This is probably because gcc already uses bp for the frame pointer,
adding -momit-leaf-frame-pointer makes the error go away.
> > * inet/test-ifaddrs.c (addr_string): Surround AF_PACKET case with
> > #ifdef AF_PACKET.
> > * sysdeps/mach/hurd/getcwd.c
> > (_hurd_canonicalize_directory_name_intern): Only realloc when
> > size is <= 0.
> > * sysdeps/mach/hurd/mmap.c (__mmap): Fail when addr or offset
> > isn't page aligned.
> > * sysdeps/mach/hurd/spawni.c (EXPAND_DTABLE): Set dtablesize to
> > new size.
>
> These changes are unrelated and the log entries should not be grouped into
> a paragraph.
Here is a corrected changelog:
2004-05-07 Jeroen Dekkers <jeroen@dekkers.cx>
* sysdeps/mach/hurd/i386/Makefile (CFLAGS-init-first.c): Add
-momit-leaf-frame-pointer.
* inet/test-ifaddrs.c (addr_string): Surround AF_PACKET case with
#ifdef AF_PACKET.
* sysdeps/mach/hurd/getcwd.c
(_hurd_canonicalize_directory_name_intern): Only realloc when
size is <= 0.
* sysdeps/mach/hurd/mmap.c (__mmap): Fail when addr or offset
isn't page aligned.
* sysdeps/mach/hurd/spawni.c (EXPAND_DTABLE): Set dtablesize to
new size.
* sysdeps/mach/hurd/Versions (GLIBC_PRIVATE): Add __libc_read,
__libc_write and __libc_lseek64.
Jeroen Dekkers