This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Sysdeps changes for hppa.


Ulrich,

> I've applied this patch, but only because I really don't care how the PA
> port looks.

I didn't think the patch was too ugly, but then again a father thinks
all his children are beautiful.

> The semtimedop definition is completely wrong.  If you want all
> syscall,s use appropriate headers.

Moot point. We know why it's there, because changes don't propagate
everywhere as fast as we'd like.

> You've modified the patch by hand and broke it, forcing me to do clean up.

Unforgivable. Please reject patches immediately if this happens again. 
I will produce a correct patch.

> The coding style is completely wrong and a terrible mess.  The coding
> standard document is available, read it.

Suggestions accepted. I will reread the document.
 
> The preprocessor directive indentation is wrong or non-existing.

Never non-existent. Incorrect yes.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]