This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: PATCH: Fix struct stat [__USE_FILE_OFFSET64] insysdeps/unix/sysv/linux/bits/stat.h
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: schwab at suse dot de
- Cc: hans-peter dot nilsson at axis dot com, libc-alpha at sources dot redhat dot com, dev-etrax at pulsar dot homelinux dot net
- Date: Wed, 4 Jun 2003 21:48:15 +0200
- Subject: Re: PATCH: Fix struct stat [__USE_FILE_OFFSET64] insysdeps/unix/sysv/linux/bits/stat.h
> From: Andreas Schwab <schwab@suse.de>
> Date: Wed, 04 Jun 2003 21:32:50 +0200
> Hans-Peter Nilsson <hans-peter.nilsson@axis.com> writes:
> |> > From: Andreas Schwab <schwab@suse.de>
> |> > Date: Wed, 04 Jun 2003 19:57:45 +0200
> |> > Because that will be a binary incompatible change.
> |>
> |> That's my point (made several times now): it will *not* be a
> |> binary incompatible change. Nowhere.
>
> But _removing_ the padding is. That's the point I was making: the padding
> became useless as soon as dev_t started growing.
Huh?
I'm not removing any padding. Hum, the patch format may be
playing tricks with you. Look closer at the patch. I'm moving
the padding from *outside* the #ifndef/#else __USE_FILE_OFFSET64
to *inside each arm*. Maybe a "cvs diff -up" would have been
clearer in this case. (My default is -cp as per GCC rules.)
Is that what got you or are there other issues?
brgds, H-P