This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: p{read,write}{,64} mips n64 changes
- From: Andreas Jaeger <aj at suse dot de>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Sat, 15 Mar 2003 07:19:41 +0100
- Subject: Re: p{read,write}{,64} mips n64 changes
- References: <or8yvi80qw.fsf@free.redhat.lsd.ic.unicamp.br>
Alexandre Oliva <aoliva at redhat dot com> writes:
> @@ -59,8 +65,13 @@ __libc_pread (fd, buf, count, offset)
> {
> /* First try the syscall. */
> assert (sizeof (offset) == 4);
> +#if defined _ABI64 && _MIPS_SIM == _ABI64
> + result = INLINE_SYSCALL (pread, 6, fd, CHECK_N (buf, count), count, 0,
> + offset);
> +#else
> result = INLINE_SYSCALL (pread, 6, fd, CHECK_N (buf, count), count, 0,
> __LONG_LONG_PAIR (offset >> 31, offset));
Can't we use a macro here that does the right thing?
E.g. __LONG_LONG_ARGUMENT (offset) which extends on n64 to just offset
and on other ABIs to __LONG_LONG_PAIR ?
Andreas
--
Andreas Jaeger
SuSE Labs aj at suse dot de
private aj at arthur dot inka dot de
http://www.suse.de/~aj