Changelog question

[Steve Munroe <sjmunroe at vnet dot ibm dot com>]

OOPS sent to the wrong file. This is the current question.

OK I am trying to clean up my Changelogs and follow all the rules. But I 
still foggy on the exact rules for change logging Makefiles. For example 
is the following OK? Is all this detail useful? Or is this too much detail?


2002-07-29  Steven Munroe  <sjmunroe@us.ibm.com>

	* sysdeps/powerpc/Makefile(cflags): Remove powerpc32 specific cflags.
	($(with-fp) = no): Move test to powerpc32/Makefile.
	($(subdir) = misc): Move to powerpc32/Makefile.
	($(build-shared) = yes): Move to powerpc32/Makefile.
	($(subdir) = csu): Move to powerpc32/Makefile.
	(sysdep-rtld-routines): Remove dl-start. 
	* sysdeps/powerpc/powerpc32/Makefile: New file.  Specify powerpc32 
	specific cflags -Wa,-mppc. Include powerpc32 specific tests and 
	symbols removed from powerpc/Makefile. 
	(sysdep-rtld-routines): Add dl-start. 
	
	
diff -rc2PN libc23-cvstip-20020823/sysdeps/powerpc/Makefile libc23/sysdeps/powerpc/Makefile
*** libc23-cvstip-20020823/sysdeps/powerpc/Makefile	Tue Aug 20 16:26:56 2002
--- libc23/sysdeps/powerpc/Makefile	Fri Aug 23 13:49:21 2002
***************
*** 1,11 ****
  # We always want to use the new mnemonic syntax even if we are on a RS6000
  # machine.
! +cflags += -mnew-mnemonics -Wa,-mppc -mpowerpc
! asm-CPPFLAGS += -Wa,-mppc
! 
! ifeq ($(with-fp),no)
! +cflags += -msoft-float
! sysdep-LDFLAGS += -msoft-float
! endif
  
  ifeq ($(subdir),gmon)
--- 1,7 ----
+ # Build options common to powerpc32 and powerpc64
+ # This is ./sysdeps/powerpc/Makefile
  # We always want to use the new mnemonic syntax even if we are on a RS6000
  # machine.
! +cflags += -mnew-mnemonics 
  
  ifeq ($(subdir),gmon)
***************
*** 13,50 ****
  endif
  
- ifeq ($(subdir),misc)
- sysdep_routines += gprsave0 gprrest0 gprsave1 gprrest1
- endif
- 
- # On PPC, -fpic works until the GOT contains 2^15 bytes, and possibly
- # more depending on how clever the linker is.  Each GOT entry takes 4 bytes,
- # so that's at least 8192 entries.  Since libc only uses about 2000 entries,
- # we want to use -fpic, because this generates fewer relocs.
- ifeq (yes,$(build-shared))
- pic-ccflag = -fpic
- endif
- 
- ifeq ($(subdir),csu)
- ifneq ($(elf),no)
- # The initfini generation code doesn't work in the presence of -fPIC, so
- # we use -fpic instead which is much better.
- CFLAGS-initfini.s = -g0 -fpic -O1
- 
- # There is no benefit to using sdata for these objects, and the user
- # of the library should be able to control what goes into sdata.
- CFLAGS-init.o = -G0
- CFLAGS-gmon-start.o = -G0
- endif
- ifeq (yes,$(build-shared))
- # Compatibility
- ifeq (yes,$(have-protected))
- CPPFLAGS-divdi3.c = -DHAVE_DOT_HIDDEN
- CPPFLAGS-libgcc-compat.S = -DHAVE_DOT_HIDDEN
- endif
- sysdep_routines += divdi3 libgcc-compat
- shared-only-routines += divdi3 libgcc-compat
- endif
- endif
- 
  ifeq ($(subdir),string)
  CFLAGS-memcmp.c += -Wno-uninitialized
--- 9,12 ----
***************
*** 56,59 ****
  sysdep_routines += dl-machine
  # extra shared linker files to link only into dl-allobjs.so
! sysdep-rtld-routines += dl-machine dl-start
  endif
--- 18,21 ----
  sysdep_routines += dl-machine
  # extra shared linker files to link only into dl-allobjs.so
! sysdep-rtld-routines += dl-machine
  endif	
diff -rc2PN libc23-cvstip-20020823/sysdeps/powerpc/powerpc32/Makefile libc23/sysdeps/powerpc/powerpc32/Makefile
*** libc23-cvstip-20020823/sysdeps/powerpc/powerpc32/Makefile	Wed Dec 31 18:00:00 1969
--- libc23/sysdeps/powerpc/powerpc32/Makefile	Fri Aug 23 13:47:33 2002
***************
*** 0 ****
--- 1,49 ----
+ # Powerpc32 specific build options.
+ # this is ./sysdeps/powerpc/powerpc32/Makefile
+ 
+ +cflags += -Wa,-mppc -mpowerpc
+ asm-CPPFLAGS += -Wa,-mppc
+ 
+ ifeq ($(with-fp),no)
+ +cflags += -msoft-float
+ sysdep-LDFLAGS += -msoft-float
+ endif
+ 
+ ifeq ($(subdir),misc)
+ sysdep_routines += gprsave0 gprrest0 gprsave1 gprrest1
+ endif
+ 
+ # On PPC, -fpic works until the GOT contains 2^15 bytes, and possibly
+ # more depending on how clever the linker is.  Each GOT entry takes 4 bytes,
+ # so that's at least 8192 entries.  Since libc only uses about 2000 entries,
+ # we want to use -fpic, because this generates fewer relocs.
+ ifeq (yes,$(build-shared))
+ pic-ccflag = -fpic
+ endif
+ 
+ ifeq ($(subdir),csu)
+ ifneq ($(elf),no)
+ # The initfini generation code doesn't work in the presence of -fPIC, so
+ # we use -fpic instead which is much better.
+ CFLAGS-initfini.s = -g0 -fpic -O1
+ 
+ # There is no benefit to using sdata for these objects, and the user
+ # of the library should be able to control what goes into sdata.
+ CFLAGS-init.o = -G0
+ CFLAGS-gmon-start.o = -G0
+ endif
+ ifeq (yes,$(build-shared))
+ # Compatibility
+ ifeq (yes,$(have-protected))
+ CPPFLAGS-divdi3.c = -DHAVE_DOT_HIDDEN
+ CPPFLAGS-libgcc-compat.S = -DHAVE_DOT_HIDDEN
+ endif
+ sysdep_routines += divdi3 libgcc-compat
+ shared-only-routines += divdi3 libgcc-compat
+ endif
+ endif
+ 
+ ifeq ($(subdir),elf)
+ # extra shared linker files to link only into dl-allobjs.so
+ sysdep-rtld-routines += dl-start
+ endif