This is the mail archive of the libc-alpha@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] i386 strtok.S optimization


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jhair Tocancipa Triana wrote:
Hi,

This short patch drops out the current loop to terminate tokens. When
a delimiter is found the token is terminated immediately.
We need now to distinguish between NULL and not NULL tokens (the
latter not allowed by the definition of strtok). This results in a
shorter version of strtok.S, though.
Shorter isn't necessarily faster. I haven't tested the code yet due to time constraints. Please run some tests and time them. And then provide a patch without any changes to the white spaces and without dropping the opcode extensions like b,w,l. Doing so only makes reading the patch more difficult.

- -- - ---------------. ,-. 1325 Chesapeake Terrace
Ulrich Drepper \ ,-------------------' \ Sunnyvale, CA 94089 USA
Red Hat `--' drepper at redhat.com `------------------------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQE9ZwO52ijCOnn/RHQRAtLFAKCoPmQspcgoNr3sJOACCiNGQWzDRACeP02K
p9Fz/ui8tdX5KjdUjlsnuS0=
=xE9r
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]