This is the mail archive of the
libc-alpha@sources.redhat.com
mailing list for the glibc project.
Re: [PATCH] for POSIX timer code
- From: Andreas Jaeger <aj at suse dot de>
- To: george anzinger <george at mvista dot com>
- Cc: "libc-alpha at sources dot redhat dot com" <libc-alpha at sources dot redhat dot com>
- Date: Fri, 08 Mar 2002 14:02:00 +0100
- Subject: Re: [PATCH] for POSIX timer code
- References: <3C8804CD.77504E3C@mvista.com>
george anzinger <george@mvista.com> writes:
> Having set info.si_code to SI_TIMER it seems inappropriate to then set
> union fields that relate to some other field. Here we suggest a change
> to set the timer1 field to the timer ID. This is compatible with the
> high-res-timers code which we hope to get in the kernel.
But doesn't this change current behaviour? Is the changed behaviour
according to the standards? Changing glibc to conform to your
implementation is not a good reason for me.
> It seem highly unlikely that anyone would be using this info in the
> current implementation.
George, thanks for the submission. Even when Ulrich has to review it
properly, let me add some comments on style. In glibc we use the GNU
Coding style rules which means that code should be indented correctly,
and documented properly:
- Please send next time a ChangeLog entry (as plain text)
> -g
>
>
> ---
> /usr/src/incoming/glibc/glibc-2.2.5-hr/linuxthreads/sysdeps/pthread/timer_routines.c~
> Sat Apr 21 13:42:42 2001
> +++
> /usr/src/incoming/glibc/glibc-2.2.5-hr/linuxthreads/sysdeps/pthread/timer_routines.c
> Thu Mar 7 16:16:55 2002
> @@ -333,8 +333,7 @@
> value. */
> info.si_signo = timer->event.sigev_signo;
> info.si_code = SI_TIMER;
> - info.si_pid = timer->creator_pid;
> - info.si_uid = getuid ();
> + info.si_timer1 = timer_ptr2id(timer);
- Use tabs instead of spaces (check the lines you removed and the one
you added) at the beginning
- Add a space before a brace
- btw. if you like to have your code in glibc, we need a proper
copyright assignment. Ask me off-list for details.
Thanks,
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj